DRAFT!!! Remove unneeded includes

[iklam]

This is done semi-automatically with a Linux/x64 fastdebug build.

Manual testing is needed because run-clang-tidy reports some false positives.

$ make compile-commands
$ run-clang-tidy -p . -j 12 -checks='-*,misc-include-cleaner' \
     '.*/src/hotspot/share/runtime/.*\.(c|cc|cpp|cxx)$' > clang-tidy.txt  2>&1 

$ grep used.directly clang-tidy.txt
/repo/open/src/hotspot/share/runtime/stubRoutines.cpp:37:1: warning: included header align.hpp is not used directly [misc-include-cleaner]
/repo/open/src/hotspot/share/runtime/stubRoutines.cpp:40:1: warning: included header runtime.hpp is not used directly [misc-include-cleaner]

I have a script that tries all the suggestions of clang-tidy.txt. E.g.,

• Edit stubRoutines.cpp to change the include to //NONEED #include "utilities/align.hpp"
• Rebuild stubRoutines.o.
  • If all goes well, leave the line as is.
  • If the build fails, change the line to /*NEED*/ #include "utilities/align.hpp"

After about 100 fixes, I run the repo in our Mach5 CI to build on a wide range of platforms and configurations. Change the //NONEED to /*NEED*/ when failures are found. Usually failures happen only with a small number of lines.

Do the above for a few iterations. When I am happy with the changes, I will run another script to remove all the //NONEED lines, and also remove all the /*NEED*/ comments.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32032/head:pull/32032
$ git checkout pull/32032

Update a local copy of the PR:
$ git checkout pull/32032
$ git pull https://git.openjdk.org/jdk.git pull/32032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32032

View PR using the GUI difftool:
$ git pr show -t 32032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32032.diff

[bridgekeeper]

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@iklam The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.