8388872: Avoid unused variables warnings in libj2pkcs11#32028
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
|
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
When building a product build with additionally enabled unused initialized variables warnings (e.g. C4189 MSVC warning) we get some warnings/errors in libj2pkcs11 because of variables only used in debug code.
This can and should be avoided.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32028/head:pull/32028$ git checkout pull/32028Update a local copy of the PR:
$ git checkout pull/32028$ git pull https://git.openjdk.org/jdk.git pull/32028/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32028View PR using the GUI difftool:
$ git pr show -t 32028Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32028.diff
Using Webrev
Link to Webrev Comment