Skip to content

8388872: Avoid unused variables warnings in libj2pkcs11#32028

Open
MBaesken wants to merge 1 commit into
openjdk:masterfrom
MBaesken:JDK-8388872
Open

8388872: Avoid unused variables warnings in libj2pkcs11#32028
MBaesken wants to merge 1 commit into
openjdk:masterfrom
MBaesken:JDK-8388872

Conversation

@MBaesken

@MBaesken MBaesken commented Jul 23, 2026

Copy link
Copy Markdown
Member

When building a product build with additionally enabled unused initialized variables warnings (e.g. C4189 MSVC warning) we get some warnings/errors in libj2pkcs11 because of variables only used in debug code.
This can and should be avoided.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8388872: Avoid unused variables warnings in libj2pkcs11 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32028/head:pull/32028
$ git checkout pull/32028

Update a local copy of the PR:
$ git checkout pull/32028
$ git pull https://git.openjdk.org/jdk.git pull/32028/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32028

View PR using the GUI difftool:
$ git pr show -t 32028

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32028.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 23, 2026

Copy link
Copy Markdown

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 23, 2026

Copy link
Copy Markdown

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8388872: Avoid unused variables warnings in libj2pkcs11

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 30a48df: 8388841: Remove logging tag monitortable
  • 30471d7: 8388507: DecimalFormat Strict Parsing NaN and Grouping Size Zero Fixes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title JDK-8388872: Avoid unused variables warnings in libj2pkcs11 8388872: Avoid unused variables warnings in libj2pkcs11 Jul 23, 2026
@openjdk openjdk Bot added the security security-dev@openjdk.org label Jul 23, 2026
@openjdk

openjdk Bot commented Jul 23, 2026

Copy link
Copy Markdown

@MBaesken The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 23, 2026
@mlbridge

mlbridge Bot commented Jul 23, 2026

Copy link
Copy Markdown

Webrevs

@valeriepeng valeriepeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks~
BTW, I added a noreg-cleanup label to the bug record since there is no regression test.

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants