8388849: javax/swing/JInternalFrame/8069348/bug8069348.java should ignore execution in non-Windows platform if sun.java2d.d3d=true

[prsadhuk]

Test should not run in non-WIndows platform if sun.java2d.d3d=true but isSupported call in the test checks for Boolean.getBoolean(d3d) which returns false as it treats "true" as the name of another system property
so we need to use Boolean.parseBoolean which returns true and isSupported in that case returns false
so that test should be ignored for non-Windows platform if d3d is true

Since 1st @run execution already tests for default pipeline in non-Windows platform, there's no need to run it again if d3d is true

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8388849: javax/swing/JInternalFrame/8069348/bug8069348.java should ignore execution in non-Windows platform if sun.java2d.d3d=true (Bug - P4)

Reviewers

• Alexander Zvegintsev (@azvegint - Reviewer)
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32024/head:pull/32024
$ git checkout pull/32024

Update a local copy of the PR:
$ git checkout pull/32024
$ git pull https://git.openjdk.org/jdk.git pull/32024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32024

View PR using the GUI difftool:
$ git pr show -t 32024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32024.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8388849: javax/swing/JInternalFrame/8069348/bug8069348.java should ignore execution in non-Windows platform if sun.java2d.d3d=true

Reviewed-by: azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 2d1c833: 8388459: RISC-V: Add specialized CMove patterns with zero operand
• 3859931: 8387645: Replace obsolete sun.java2d.noddraw property with sun.java2d.d3d
• 1bc03f0: 8388827: Unused Gen.CodeSizeOverflow
• ... and 21 more: https://git.openjdk.org/jdk/compare/4bbe11186ffa79da62d86f804643d1dd91b89177...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: client. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e1f0b46b)
• 00: Full (6cb461ee)

[prrace]

The method looked weird, partly because of the name "isSupported() and I wondered it is trying to achieve

The only thing it does is prevent this invocation from running on mac & linux

@run main/othervm -Dsun.java2d.d3d=true -Dsun.java2d.uiScale=2 bug8069348

presumably because it duplicates this invocation :

@run main/othervm -Dsun.java2d.uiScale=2 bug8069348

But it wasn't stopping the same duplication on macOS .. in the ORIGINAL version of the test

44 * @run main/othervm -Dsun.java2d.opengl=true -Dsun.java2d.uiScale=2 bug8069348

was the default until metal came along

It was removed by https://hg.openjdk.org/jdk/jdk/rev/3b820b878ebe

So some of what isSupported() was trying to achieve is obsoleted.

And anywatd3d is the default on windows where we can enable it and specifying the property doesn't change anything.
i.e it does not force-enable it.

I think to be useful it should have been

@run main/othervm -Dsun.java2d.d3d=false -Dsun.java2d.uiScale=2 bug8069348

then WHERE SUPPORTED this default line would be running the d3d case

@run main/othervm -Dsun.java2d.uiScale=2 bug8069348

So I suggest to just ditch the isSupported() method and use just the default

@run main/othervm -Dsun.java2d.uiScale=2 bug8069348

[prrace]

PS .. if you really still want to run it with different platforms and different options, then add
multiple @test blocks with @requires tags

[prsadhuk]

Removed isSupported and used the default pipeline

[prsadhuk]

@azvegint Can you please re-review it?

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 3d44c66.
Since your change was applied there have been 24 commits pushed to the master branch:

• 2d1c833: 8388459: RISC-V: Add specialized CMove patterns with zero operand
• 3859931: 8387645: Replace obsolete sun.java2d.noddraw property with sun.java2d.d3d
• 1bc03f0: 8388827: Unused Gen.CodeSizeOverflow
• ... and 21 more: https://git.openjdk.org/jdk/compare/4bbe11186ffa79da62d86f804643d1dd91b89177...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 3d44c66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.