Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Dec 29, 2025

  • Replace Files.newInputStream(path) in chain method calls with either new ByteArrayInputStream(Files.readAllBytes(path)) or path.toFile() if there is an alternative method taking a File instance instead of an InputStream and if appropriate.
  • Add missing try-with-resources for Class.getResourceAsStream() calls.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29007/head:pull/29007
$ git checkout pull/29007

Update a local copy of the PR:
$ git checkout pull/29007
$ git pull https://git.openjdk.org/jdk.git pull/29007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29007

View PR using the GUI difftool:
$ git pr show -t 29007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29007.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 29, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 29, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@alexeysemenyukoracle alexeysemenyukoracle force-pushed the close-streams branch 3 times, most recently from b3ed452 to c468e94 Compare January 2, 2026 16:22
@openjdk
Copy link

openjdk bot commented Jan 2, 2026

@alexeysemenyukoracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout close-streams
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jan 2, 2026
@alexeysemenyukoracle alexeysemenyukoracle changed the title Close unclosed opened streams Close unclosed streams Jan 2, 2026
…th DocumentBuilder.parse(File) whichever suits better.
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant