Skip to content

Conversation

@thswlsqls
Copy link
Contributor

@thswlsqls thswlsqls commented Dec 27, 2025

Summary

Fix typo in VirtualThreadSchedulerMXBean Javadoc: "suppored" → "supported".

Description

Line 79 in VirtualThreadSchedulerMXBean.java contains a typo in the @throws UnsupportedOperationException documentation. The word "suppored" is corrected to "supported".

Bug ID : JDK-8374373

https://bugs.java.com/bugdatabase/view_bug?bug_id=8374373


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374373: Typo in VirtualThreadSchedulerMXBean.setParallelism javadoc (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29002/head:pull/29002
$ git checkout pull/29002

Update a local copy of the PR:
$ git checkout pull/29002
$ git pull https://git.openjdk.org/jdk.git pull/29002/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29002

View PR using the GUI difftool:
$ git pr show -t 29002

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29002.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2025

👋 Welcome back thswlsqls! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 27, 2025

@thswlsqls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374373: Typo in VirtualThreadSchedulerMXBean.setParallelism javadoc

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Dec 27, 2025

@thswlsqls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 27, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2025

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is okay. Can you update the PR title to align with the JBS issue?

@thswlsqls thswlsqls changed the title 8374373: Correct typo in VirtualThreadSchedulerMXBean.java Javadoc 8374373: Typo in VirtualThreadSchedulerMXBean.setParallelism javadoc Dec 29, 2025
@openjdk
Copy link

openjdk bot commented Dec 29, 2025

⚠️ @thswlsqls the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8374373-fix-VirtualThreadSchedulerMXBean-javadoc-typo
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 29, 2025
@thswlsqls
Copy link
Contributor Author

thswlsqls commented Dec 29, 2025

@AlanBateman Thanks for the review.

I’ve updated the PR title to match the JBS issue title.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@AlanBateman The change author (@thswlsqls) must issue an integrate command before the integration can be sponsored.

@thswlsqls
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 31, 2025
@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@thswlsqls
Your change (at version 410b5e3) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 1, 2026

Going to push as commit 752f46d.
Since your change was applied there have been 100 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 1, 2026
@openjdk openjdk bot closed this Jan 1, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 1, 2026
@openjdk
Copy link

openjdk bot commented Jan 1, 2026

@AlanBateman @thswlsqls Pushed as commit 752f46d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants