Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Dec 25, 2025

The copyright year in "test/langtools/tools/javac/" files updated in 2025 has been bumped to 2025.

The next command can be run (on top of this PR) to verify that each file had prior commits in 2025:

git diff HEAD~1 --name-only | while read f; do git log HEAD~1 --since="2025-01-01" --oneline -- "$f" | head -1 | grep -q . || echo "NOT IN 2025: $f"; done


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374352: Update copyright year to 2025 for test/langtools/tools/javac/ in files where it was missed (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28989/head:pull/28989
$ git checkout pull/28989

Update a local copy of the PR:
$ git checkout pull/28989
$ git pull https://git.openjdk.org/jdk.git pull/28989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28989

View PR using the GUI difftool:
$ git pr show -t 28989

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28989.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 25, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 25, 2025

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374352: Update copyright year to 2025 for test/langtools/tools/javac/ in files where it was missed

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 25, 2025

@mrserb The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review December 25, 2025 07:04
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 25, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 25, 2025

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 30, 2025

Looking for volunteers to review this patch. It cannot be integrated in 2026.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 31, 2025
@mrserb
Copy link
Member Author

mrserb commented Dec 31, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 31, 2025

Going to push as commit 481ef1d.
Since your change was applied there have been 21 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 31, 2025
@openjdk openjdk bot closed this Dec 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 31, 2025
@openjdk
Copy link

openjdk bot commented Dec 31, 2025

@mrserb Pushed as commit 481ef1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the copy_javac branch December 31, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants