8374342: Remove incorrect @throws NoSuchFileException from FileUtils.java #28985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove incorrect @throws documentation from FileUtils.deleteFileIfExistsWithRetry.
Description
The method documentation states that no exception is thrown if the file does not exist.
The implementation checks file existence before deletion and does not throw NoSuchFileException in this case.
This change removes the contradictory @throws clause.
No behavior is changed.
Bug ID : JDK-8374342
https://bugs.java.com/bugdatabase/view_bug?bug_id=8374342
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28985/head:pull/28985$ git checkout pull/28985Update a local copy of the PR:
$ git checkout pull/28985$ git pull https://git.openjdk.org/jdk.git pull/28985/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28985View PR using the GUI difftool:
$ git pr show -t 28985Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28985.diff
Using Webrev
Link to Webrev Comment