8374342: Remove incorrect @throws NoSuchFileException from test/lib/jdk/test/lib/util/FileUtils.javaFileUtils.java

[thswlsqls]

Summary

Remove incorrect @throws documentation from FileUtils.deleteFileIfExistsWithRetry.

Description

The method documentation states that no exception is thrown if the file does not exist.
The implementation checks file existence before deletion and does not throw NoSuchFileException in this case.
This change removes the contradictory @throws clause.
No behavior is changed.

Bug ID : JDK-8374342

https://bugs.java.com/bugdatabase/view_bug?bug_id=8374342

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374342: Remove incorrect @throws NoSuchFileException from test/lib/jdk/test/lib/util/FileUtils.javaFileUtils.java (Bug - P4)

Reviewers

• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28985/head:pull/28985
$ git checkout pull/28985

Update a local copy of the PR:
$ git checkout pull/28985
$ git pull https://git.openjdk.org/jdk.git pull/28985/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28985

View PR using the GUI difftool:
$ git pr show -t 28985

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28985.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thswlsqls! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@thswlsqls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374342: Remove incorrect @throws NoSuchFileException from test/lib/jdk/test/lib/util/FileUtils.javaFileUtils.java

Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 186 new commits pushed to the master branch:

• c8c6e70: 8374825: vmTestbase comment typo: lunch
• 2a965df: 8374377: PNGImageDecoder Slow For 8-bit PNGs
• a855224: 8373695: G1: Using a value near integer max for ActiveProcessorCount causes fatal crash
• ... and 183 more: https://git.openjdk.org/jdk/compare/5e7ae281326ca306339aaba101d4206dffdb9ca0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Michael-Mc-Mahon) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@thswlsqls The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (373caa97)

[Michael-Mc-Mahon]

This seems reasonable. You will need to update the PR title to match the change I made to the bug title.

[thswlsqls]

@Michael-Mc-Mahon Thank you for the review. I updated the PR title to match bug title : JDK-8374342

[Michael-Mc-Mahon]

You need to prefix the PR title with the bugid as it was before. ie.

8374342: Remove incorrect @throws NoSuchFileException from test/lib/jdk/test/lib/util/FileUtils.javaFileUtils.java

[thswlsqls]

@Michael-Mc-Mahon Thank you. I restored the PR title. /integrate

[openjdk]

⚠️ @thswlsqls the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout JDK-8374342-fix-fileutils-doc
$ git commit --author='Preferred Full Name <[email protected]>' --allow-empty -m 'Update full name'
$ git push