8374341: Use of "\s" instead of "\\s" in CoreUtils.java results in splitting on backspace instead of whitespace #28984
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect regex usage in CoreUtils.getCoreFileLocation.
Description
CoreUtils.getCoreFileLocation uses String.split("\s", 2).
The string literal "\s" represents a backspace character, not a whitespace regex.
As a result, the split operation does not separate fields on whitespace.
This change replaces the pattern with
"\\s+"to correctly split on whitespace.No other logic is modified.
Bug ID : JDK-8374341
https://bugs.java.com/bugdatabase/view_bug?bug_id=8374341
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28984/head:pull/28984$ git checkout pull/28984Update a local copy of the PR:
$ git checkout pull/28984$ git pull https://git.openjdk.org/jdk.git pull/28984/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28984View PR using the GUI difftool:
$ git pr show -t 28984Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28984.diff
Using Webrev
Link to Webrev Comment