8374343: Fix SIGSEGV when lib/modules is unreadable

[bulasevich]

The JVM crashes with a SIGSEGV during startup if the runtime image (lib/modules) exists but is unreadable. In this scenario, ClassLoader::get_jrt_entry() returns nullptr, leading to a crash. This change adds a null check to avoid the dereference and bail out gracefully.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8374343: Fix SIGSEGV when lib/modules is unreadable (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28982/head:pull/28982
$ git checkout pull/28982

Update a local copy of the PR:
$ git checkout pull/28982
$ git pull https://git.openjdk.org/jdk.git pull/28982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28982

View PR using the GUI difftool:
$ git pr show -t 28982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28982.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@bulasevich The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f3da8c82)

[AlanBateman]

if the runtime image (lib/modules) exists but is unreadable.

AOT aside, does this scenario cause problems elsewhere? The JDK has to work with both images and interim exploded builds. I'm wondering if other parts of the runtime will assume an exploded build (and fail) if lib/modules is not accessile.

[bulasevich]

if the runtime image (lib/modules) exists but is unreadable.

AOT aside, does this scenario cause problems elsewhere? The JDK has to work with both images and interim exploded builds. I'm wondering if other parts of the runtime will assume an exploded build (and fail) if lib/modules is not accessile.

The JDK has to work with both images and interim exploded builds. I'm wondering if other parts of the runtime will assume an exploded build (and fail) if lib/modules is not accessile.

The change is fail-fast: when lib/modules exists but is unreadable, we now report a clear error and exit cleanly instead of crashing:

 [0.032s][warning][class,path] Runtime image (modules) is unreadable or missing - validation failed
 Error occurred during initialization of VM
 java/lang/NoClassDefFoundError: java/lang/Object

I checked also the interim exploded build case. With broken permissions on lib/modules, there is no SIGSEGV or undefined behavior; the runtime reports an error and exits cleanly.

Let me know if you have a concrete failure scenario in mind. I will check it.

[dholmes-ora]

To get to the point where we crash this way a lot of stuff under lib has to exist and be readable (e.g. native libs), so why is modules not readable?