-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374322: TestMemoryWithSubgroups.java fails Permission denied #28975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 54 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
|
I think this has been discussed in the past and it was considered a test environment configuration error and so should be reported rather than being silently ignored. |
Okey. Thanks David. I will close this issue as 'not a issue' |
This reverts commit be21ae5.
|
/check |
|
@sendaoYan Unknown command |
I reopen this PR, since JDK-8374322 and JDK-8351382 are the different issues. |
test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java
Outdated
Show resolved
Hide resolved
|
I am running this through our tier5 testing ... |
dholmes-ora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test passed. Fix seems fine for our CI.
Thanks
|
Thanks David for the reviews and verify. Looking for 2rd reviewer since touch the hotspot files. |
Hi all,
Test containers/docker/TestMemoryWithSubgroups.java fails on some docker images. If the default user inside docker is non root user, test will report fails "mkdir: cannot create directory '/sys/fs/cgroup/memory': Permission denied". This PR add docker run parameter
--user rootto force use root user inside docker containter.Change has been verified locally on ubuntu22(cgroup v2). Test-fix only, no risk.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28975/head:pull/28975$ git checkout pull/28975Update a local copy of the PR:
$ git checkout pull/28975$ git pull https://git.openjdk.org/jdk.git pull/28975/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28975View PR using the GUI difftool:
$ git pr show -t 28975Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28975.diff
Using Webrev
Link to Webrev Comment