Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 24, 2025

Hi all,

Test containers/docker/TestMemoryWithSubgroups.java fails on some docker images. If the default user inside docker is non root user, test will report fails "mkdir: cannot create directory '/sys/fs/cgroup/memory': Permission denied". This PR add docker run parameter --user root to force use root user inside docker containter.

Change has been verified locally on ubuntu22(cgroup v2). Test-fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374322: TestMemoryWithSubgroups.java fails Permission denied (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28975/head:pull/28975
$ git checkout pull/28975

Update a local copy of the PR:
$ git checkout pull/28975
$ git pull https://git.openjdk.org/jdk.git pull/28975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28975

View PR using the GUI difftool:
$ git pr show -t 28975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28975.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374322: TestMemoryWithSubgroups.java fails Permission denied

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2025

Webrevs

@dholmes-ora
Copy link
Member

dholmes-ora commented Jan 6, 2026

I think this has been discussed in the past and it was considered a test environment configuration error and so should be reported rather than being silently ignored.

@sendaoYan
Copy link
Member Author

I think this has been discussed in the past and it was considered a test environment configuration error and so should be reported rather than being silently ignored.

Okey. Thanks David.

I will close this issue as 'not a issue'

@sendaoYan sendaoYan closed this Jan 6, 2026
@sendaoYan sendaoYan reopened this Jan 6, 2026
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 6, 2026
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 6, 2026
@sendaoYan
Copy link
Member Author

/check

@openjdk
Copy link

openjdk bot commented Jan 6, 2026

@sendaoYan Unknown command check - for a list of valid commands use /help.

@sendaoYan
Copy link
Member Author

I will close this issue as 'not a issue'

I reopen this PR, since JDK-8374322 and JDK-8351382 are the different issues.

@dholmes-ora
Copy link
Member

I am running this through our tier5 testing ...

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed. Fix seems fine for our CI.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 6, 2026
@sendaoYan
Copy link
Member Author

Thanks David for the reviews and verify.

Looking for 2rd reviewer since touch the hotspot files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants