-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8370156: Fix jpackage IconTest #27883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8370156: Fix jpackage IconTest #27883
Conversation
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@alexeysemenyukoracle this pull request can not be integrated into git checkout JDK-8370156
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@sashamatveev PTAL |
112d042
to
4d43f93
Compare
…uncherIconVerifier: make setters unambiguous; Add ConfigurationTarget
4d43f93
to
3216ddb
Compare
Rework IconTest.
Verified it produces the output as expected.
It still will not catch JDK-8370155. However, this is deliberate to avoid significant changes in the test and implementation in a single commit.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27883/head:pull/27883
$ git checkout pull/27883
Update a local copy of the PR:
$ git checkout pull/27883
$ git pull https://git.openjdk.org/jdk.git pull/27883/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27883
View PR using the GUI difftool:
$ git pr show -t 27883
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27883.diff
Using Webrev
Link to Webrev Comment