Skip to content

Conversation

alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Oct 18, 2025

Rework IconTest.

Verified it produces the output as expected.

It still will not catch JDK-8370155. However, this is deliberate to avoid significant changes in the test and implementation in a single commit.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27883/head:pull/27883
$ git checkout pull/27883

Update a local copy of the PR:
$ git checkout pull/27883
$ git pull https://git.openjdk.org/jdk.git pull/27883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27883

View PR using the GUI difftool:
$ git pr show -t 27883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27883.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2025

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 18, 2025

@alexeysemenyukoracle this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8370156
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict Pull request has merge conflict with target branch core-libs [email protected] labels Oct 18, 2025
@openjdk
Copy link

openjdk bot commented Oct 18, 2025

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2025

Webrevs

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Oct 18, 2025
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev PTAL

@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as draft October 20, 2025 13:36
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant