Skip to content

8369609: Continuations preempt_epilog is missing a call to invalidate_jvmti_stack #27878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+8 −6
Open

8369609: Continuations preempt_epilog is missing a call to invalidate_jvmti_stack #27878

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c30793f
8369609: Continuations preempt_epilog is missing a call to invalidate…
sspitsyn Oct 17, 2025
1b5a057
review: remove now unneeded call to invalidate_jvmti_stack
sspitsyn Oct 22, 2025
3edebdb
Merge
sspitsyn Oct 22, 2025
e6fc405
review: call to invalidate_jvmti_stack for pure continuations only
sspitsyn Oct 24, 2025
4a4302b
remove unintentionally added new empty line
sspitsyn Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/hotspot/share/runtime/continuationFreezeThaw.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,13 +1626,15 @@ static void invalidate_jvmti_stack(JavaThread* thread) {
}

static void jvmti_yield_cleanup(JavaThread* thread, ContinuationWrapper& cont) {
if (!cont.entry()->is_virtual_thread() && JvmtiExport::has_frame_pops(thread)) {
int num_frames = num_java_frames(cont);
if (!cont.entry()->is_virtual_thread()) {
if (JvmtiExport::has_frame_pops(thread)) {
int num_frames = num_java_frames(cont);

ContinuationWrapper::SafepointOp so(Thread::current(), cont);
JvmtiExport::continuation_yield_cleanup(JavaThread::current(), num_frames);
ContinuationWrapper::SafepointOp so(Thread::current(), cont);
JvmtiExport::continuation_yield_cleanup(thread, num_frames);
}
invalidate_jvmti_stack(thread);
}
invalidate_jvmti_stack(thread);
}

static void jvmti_mount_end(JavaThread* current, ContinuationWrapper& cont, frame top) {
Expand Down Expand Up @@ -2310,7 +2312,7 @@ NOINLINE intptr_t* Thaw<ConfigT>::thaw_slow(stackChunkOop chunk, Continuation::t

assert(_cont.chunk_invariant(), "");

JVMTI_ONLY(invalidate_jvmti_stack(_thread));
JVMTI_ONLY(if (!_cont.entry()->is_virtual_thread()) invalidate_jvmti_stack(_thread));

_thread->set_cont_fastpath(_fastpath);

Expand Down