Skip to content

Conversation

vy
Copy link
Contributor

@vy vy commented Oct 17, 2025

Validate and clamp the value populated from the jdk.httpclient.bufsize system property. Added two new tests: Does clamping work? Does the minimum value wedge the client?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367976: Validate and clamp jdk.httpclient.bufsize (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27874/head:pull/27874
$ git checkout pull/27874

Update a local copy of the PR:
$ git checkout pull/27874
$ git pull https://git.openjdk.org/jdk.git pull/27874/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27874

View PR using the GUI difftool:
$ git pr show -t 27874

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27874.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@vy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 17, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2025

Webrevs

@dfuch
Copy link
Member

dfuch commented Oct 20, 2025

You will also need to update module-info.java where the property is documented, to indicate what is the range of valid values and what happens if an invalid value is provided.

https://github.com/openjdk/jdk/blob/8c775e299dbf651c3be1ba84b9e50356a3503861/src/java.net.http/share/classes/module-info.java#L49C1-L52C9

@vy
Copy link
Contributor Author

vy commented Oct 20, 2025

You will also need to update module-info.java

Implemented in 148d426. I presume this warrants a CSR, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

net [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants