8366517: Refine null locale processing of ctor/factory methods in `Date/DecimalFormatSymbols` #27060

naotoj · 2025-09-02T19:29:37Z

Adding a @throws clause for NPE in java.text.DateFormatSymbols(Locale) constructor. The bug suggests it should throw a MissingResourceException, but I don't think we can change this long standing behavior. Instead, explicitly specify the NPE in the javadoc.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
Change requires CSR request JDK-8366735 to be approved

Issues

JDK-8366517: Refine null locale processing of ctor/factory methods in Date/DecimalFormatSymbols (Bug - P4)
JDK-8366735: Refine null locale processing of ctor/factory methods in Date/DecimalFormatSymbols (CSR)

Reviewers

Justin Lu (@justin-curtis-lu - Committer)
Roger Riggs (@RogerRiggs - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27060/head:pull/27060
$ git checkout pull/27060

Update a local copy of the PR:
$ git checkout pull/27060
$ git pull https://git.openjdk.org/jdk.git pull/27060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27060

View PR using the GUI difftool:
$ git pr show -t 27060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27060.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-09-02T19:30:25Z

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-09-02T19:31:49Z

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366517: Refine null locale processing of ctor/factory methods in `Date/DecimalFormatSymbols`

Reviewed-by: jlu, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 106 new commits pushed to the master branch:

c6c451a: 8353468: [ubsan] arguments.cpp:2422:23: runtime error: 2.14748e+11 is outside the range of representable values of type 'int'
a17058b: 8365569: Remove finalize from JavaSoundAudioClip.java
9cca4f7: 8358751: C2: Recursive inlining check for compiled lambda forms is broken
... and 103 more: https://git.openjdk.org/jdk/compare/ae9607725c8c6a1b2f2728dbb5f7993722497da7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-09-02T19:32:29Z

@naotoj The following labels will be automatically applied to this pull request:

core-libs
i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-09-02T19:35:56Z

Webrevs

justin-curtis-lu

Looks good to me and the static factory methods already specify the NPE. fyi: PR title is missing the ` around code portions.

RogerRiggs · 2025-09-03T00:57:39Z

src/java.base/share/classes/java/text/DateFormatSymbols.java

@@ -145,6 +145,7 @@ public DateFormatSymbols()
     * @throws     java.util.MissingResourceException
     *             if the resources for the specified locale cannot be
     *             found or cannot be loaded.
+     * @throws     NullPointerException if {@code locale} is null


Adding an explicit Objects.requireNull(locale, "locale") would clearly identify when the NPE is thrown.
Though it might be earlier than without the check.

Right. Added the explicit null check. (and a test case)

If we are adding an explicit check to the ctor, might we also take this opportunity to add the check to the related 1-arg factory method?

Indeed. Also did the same for DecimalFormatSymbols.

RogerRiggs · 2025-09-03T21:22:16Z

Considerable scope creep here, the issue title and PR title should be updated. And the CSR.

naotoj · 2025-09-03T21:36:47Z

Considerable scope creep here, the issue title and PR title should be updated. And the CSR.

Modified

RogerRiggs

LGTM

naotoj · 2025-09-05T20:17:56Z

Thanks for the reviews!
/integrate

openjdk · 2025-09-05T20:20:14Z

Going to push as commit 3824c7c.
Since your change was applied there have been 108 commits pushed to the master branch:

4ab2b5b: 8366569: Disable CompileTaskTimeout for known long-running test cases
e2a503e: 8347277: java/awt/Focus/ComponentLostFocusTest.java fails intermittently
c6c451a: 8353468: [ubsan] arguments.cpp:2422:23: runtime error: 2.14748e+11 is outside the range of representable values of type 'int'
... and 105 more: https://git.openjdk.org/jdk/compare/ae9607725c8c6a1b2f2728dbb5f7993722497da7...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-09-05T20:20:24Z

@naotoj Pushed as commit 3824c7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

initial commit

5007b81

openjdk bot added the csr Pull request needs approved CSR before integration label Sep 2, 2025

openjdk bot added core-libs [email protected] i18n [email protected] rfr Pull request is ready for review labels Sep 2, 2025

justin-curtis-lu approved these changes Sep 2, 2025

View reviewed changes

naotoj changed the title ~~8366517: DateFormatSymbols(Locale) throws NPE if Locale argument is null~~ 8366517: DateFormatSymbols(Locale) throws NPE if Locale argument is null Sep 2, 2025

RogerRiggs reviewed Sep 3, 2025

View reviewed changes

naotoj added 2 commits September 3, 2025 08:17

Use Objects.requireNonNull()

7b3d4e0

Further requireNonNull()

d7cb956

justin-curtis-lu approved these changes Sep 3, 2025

View reviewed changes

naotoj changed the title ~~8366517: DateFormatSymbols(Locale) throws NPE if Locale argument is null~~ 8366517: Refine null locale processing of ctor/factory methods in Date/DecimalFormatSymbols Sep 3, 2025

RogerRiggs approved these changes Sep 4, 2025

View reviewed changes

openjdk bot added ready Pull request is ready to be integrated and removed csr Pull request needs approved CSR before integration labels Sep 5, 2025

openjdk bot added the integrated Pull request has been integrated label Sep 5, 2025

openjdk bot closed this Sep 5, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8366517: Refine null locale processing of ctor/factory methods in `Date/DecimalFormatSymbols` #27060

8366517: Refine null locale processing of ctor/factory methods in `Date/DecimalFormatSymbols` #27060

Uh oh!

naotoj commented Sep 2, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Sep 2, 2025

Uh oh!

openjdk bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Sep 2, 2025

Uh oh!

mlbridge bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

justin-curtis-lu left a comment •

edited

Loading

Uh oh!

RogerRiggs Sep 3, 2025

Uh oh!

naotoj Sep 3, 2025

Uh oh!

justin-curtis-lu Sep 3, 2025

Uh oh!

naotoj Sep 3, 2025

Uh oh!

RogerRiggs commented Sep 3, 2025

Uh oh!

naotoj commented Sep 3, 2025

Uh oh!

RogerRiggs left a comment

Uh oh!

naotoj commented Sep 5, 2025

Uh oh!

openjdk bot commented Sep 5, 2025

Uh oh!

openjdk bot commented Sep 5, 2025

Uh oh!

Uh oh!

8366517: Refine null locale processing of ctor/factory methods in Date/DecimalFormatSymbols #27060

8366517: Refine null locale processing of ctor/factory methods in Date/DecimalFormatSymbols #27060

Uh oh!

Conversation

naotoj commented Sep 2, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issues

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Sep 2, 2025

Uh oh!

openjdk bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 2, 2025

Uh oh!

mlbridge bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

justin-curtis-lu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RogerRiggs Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

RogerRiggs commented Sep 3, 2025

Uh oh!

naotoj commented Sep 3, 2025

Uh oh!

RogerRiggs left a comment

Choose a reason for hiding this comment

Uh oh!

naotoj commented Sep 5, 2025

Uh oh!

openjdk bot commented Sep 5, 2025

Uh oh!

openjdk bot commented Sep 5, 2025

Uh oh!

Uh oh!

8366517: Refine null locale processing of ctor/factory methods in `Date/DecimalFormatSymbols` #27060

8366517: Refine null locale processing of ctor/factory methods in `Date/DecimalFormatSymbols` #27060

naotoj commented Sep 2, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Sep 2, 2025 •

edited

Loading

mlbridge bot commented Sep 2, 2025 •

edited

Loading

justin-curtis-lu left a comment •

edited

Loading