8366461: Remove obsolete method handle invoke logic

[dean-long]

At one time, JSR292 support needed special logic to save and restore SP across method handle instrinsic calls, but that is no longer the case. The only platform that still does the save/restore is arm32, which is no longer necessary. The save/restore can be removed along with related APIs and logic. Note that the arm32 port is largely based on the x86 port, which stopped doing the save/restore in jdk9 (JDK-8068945).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366461: Remove obsolete method handle invoke logic (Enhancement - P4)

Reviewers

• Vladimir Ivanov (@iwanowww - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27059/head:pull/27059
$ git checkout pull/27059

Update a local copy of the PR:
$ git checkout pull/27059
$ git pull https://git.openjdk.org/jdk.git pull/27059/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27059

View PR using the GUI difftool:
$ git pr show -t 27059

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27059.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dean-long This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366461: Remove obsolete method handle invoke logic

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 80fb708: 8365175: Replace Unicode extension anchor elements with link tag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dean-long The following labels will be automatically applied to this pull request:

• graal
• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (eac482a5)
• 01: Full - Incremental (303305ae)
• 00: Full (4998cacc)

[dean-long]

/label hotspot-compiler hotspot-runtime

[openjdk]

@dean-long
The hotspot-compiler label was successfully added.

The hotspot-runtime label was successfully added.

[iwanowww]

Nice cleanup! Looks good.

[dean-long]

Thanks @iwanowww !

[mhaessig]

Thank you for cleaning this up, @dean-long. I just have a drive-by comment.

[mhaessig]

<arch>Frame.java adjustUnextendedSP() do not seem to do anything? Perhaps these could be cleaned up as well?

[dean-long]

Yes, it's tempting to want to clean these up, but I noticed that SA code really tries to mirror the C++ code, so I'm inclined to leave it. Is there a Serviceability expert that would like to see this code cleaned up further? @plummercj , what do you think?

[dean-long]

I need one more review for this.