-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces #27058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces #27058
Conversation
/covered |
Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
❗ This change is not yet ready to be integrated. |
@kirill-shirokov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label hotspot-compiler |
@kirill-shirokov |
This PR addresses the trailing whitespaces for a .py test.
They were introduced in commit 916694f and not detected by jcheck, since checking *.py for whitespaces is not enabled in .jcheck/conf.
So, a separate question is: do you think that a pattern for Python files should be added to [checks "whitespace"] section of .jcheck/conf?
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27058/head:pull/27058
$ git checkout pull/27058
Update a local copy of the PR:
$ git checkout pull/27058
$ git pull https://git.openjdk.org/jdk.git pull/27058/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27058
View PR using the GUI difftool:
$ git pr show -t 27058
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27058.diff