Skip to content

Conversation

kirill-shirokov
Copy link

@kirill-shirokov kirill-shirokov commented Sep 2, 2025

This PR addresses the trailing whitespaces for a .py test.

They were introduced in commit 916694f and not detected by jcheck, since checking *.py for whitespaces is not enabled in .jcheck/conf.

So, a separate question is: do you think that a pattern for Python files should be added to [checks "whitespace"] section of .jcheck/conf?


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27058/head:pull/27058
$ git checkout pull/27058

Update a local copy of the PR:
$ git checkout pull/27058
$ git pull https://git.openjdk.org/jdk.git pull/27058/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27058

View PR using the GUI difftool:
$ git pr show -t 27058

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27058.diff

@kirill-shirokov
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 2, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2025

Hi @kirill-shirokov, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user kirill-shirokov" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 2, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@kirill-shirokov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@kirill-shirokov kirill-shirokov changed the title 8344345: File test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces 8344345: test/hotspot/gtest/x86/x86-asmtest.py has trailing whitespaces Sep 2, 2025
@kirill-shirokov
Copy link
Author

/label hotspot-compiler

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

@kirill-shirokov
The hotspot-compiler label was successfully added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant