Skip to content

Conversation

fandreuz
Copy link
Contributor

@fandreuz fandreuz commented Sep 1, 2025

In this PR I introduce some constants in StackMapGenerator. No change in logic is expected.

Passes tests in jdk/classfile.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8354871: Replace stack map frame type magics with constants (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27029/head:pull/27029
$ git checkout pull/27029

Update a local copy of the PR:
$ git checkout pull/27029
$ git pull https://git.openjdk.org/jdk.git pull/27029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27029

View PR using the GUI difftool:
$ git pr show -t 27029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27029.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2025

👋 Welcome back fandreuz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@fandreuz The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs [email protected] rfr Pull request is ready for review labels Sep 1, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2025

Webrevs

@fandreuz
Copy link
Contributor Author

fandreuz commented Sep 6, 2025

Hi @liach, could you have a look at this PR since you opened the ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant