-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8364089: JDK 25 RDP2 L10n resource files update #26467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back achung! A progress list of the required criteria for merging this PR into |
@alisenchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@alisenchung The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The JBS issue will need to be set as a P2 to be eligible for backport to 25.
@@ -86,7 +86,6 @@ MSG_BundlerFailed=Fehler: Bundler "{1}" ({0}) konnte kein Package generieren | |||
MSG_BundlerConfigException=Bundler {0} aufgrund eines Konfigurationsproblems übersprungen: {1} \nEmpfehlung zur Behebung: {2} | |||
MSG_BundlerConfigExceptionNoAdvice=Bundler {0} aufgrund eines Konfigurationsproblems übersprungen: {1} | |||
MSG_BundlerRuntimeException=Bundler {0} nicht erfolgreich. Grund: {1} | |||
MSG_BundlerFailed=Fehler: Bundler "{1}" ({0}) konnte kein Package generieren |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though there was no change in the original, it looks like they removed this entry because it was a duplicate. We should consider filing a separate issue to have the duplicate removed in the original as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justin-curtis-lu the issue has been filed and resolved already - JDK-8361697
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I missed that.
@@ -100,7 +100,7 @@ launcher.err.main.not.void=Methode "main" ist nicht mit Rückgabetyp "void" dekl | |||
launcher.err.cant.find.class=Klasse nicht gefunden: {0} | |||
|
|||
# 0: string | |||
launcher.err.cant.find.main.method=Konnte keine main(String[])- oder main()-Methode in der Klasse: {0} finden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, even though we used this suggestion last drop, the translation team rejected the translation.
jpackage changes look good |
/integrate |
Going to push as commit c671089.
Your commit was automatically rebased without conflicts. |
@alisenchung Pushed as commit c671089. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk jdk25 |
@alisenchung the backport was successfully created on the branch backport-alisenchung-c671089d-jdk25 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:
|
This issue is responsible for updating the translations of all the localize(able) resources in the JDK since the previous L10n drop.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26467/head:pull/26467
$ git checkout pull/26467
Update a local copy of the PR:
$ git checkout pull/26467
$ git pull https://git.openjdk.org/jdk.git pull/26467/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26467
View PR using the GUI difftool:
$ git pr show -t 26467
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26467.diff
Using Webrev
Link to Webrev Comment