Skip to content

8362898: Remove finalize() methods from javax.imagio TIFF classes. #26416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Jul 21, 2025

Remove finalize from TIFF ImageIO implementatation classes.

Following copied from the bug description
The TIFF image (de)compressors can make use of a JPEG reader / writer
Like all ImageIO readers and writers, once done, the owner should call their dispose() method.
This is currently done with finalize() to ensure it isn't missed.

This can be migrated to a Disposer.

However, the most common case is that it is the ImageIO built-in JPEGImageReader and JPEGImageWriter
that is located and that already implements a Disposer. So there is no need to add a Disposer for that.
We only need to add it if we find some other reader/writer.

With enough work, it might be possible for the TIFF compressor/decompressor classes to work out when
they are really done and avoid a Disposer at all. But it could also be that they instead need to discard
them when a specific task is done and then obtain a new one.
That would be much more overhead than just adding a Disposer for the rare case and regardless
of what is done in the TIFF code, the built in JPEG classes will install their own Disposer so I don't
think I want to pursue that route.

I also noticed that TIFFBaseJPEGCompressor.java can replace the current writer if it doesn't satisfy a need.
In that case it just nulls it out and doesn't call dispose() and of course finalize() will then refer to the replacement.
So I added direct calls to dispose() in such a case. That was definitely necessary with the finalize() code
but the Disposer would have taken care of it anyway, so it isn't strictly needed with the new code but
it is still good to do it early if you can.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found trailing period in issue title for 8362898: Remove finalize() methods from javax.imagio TIFF classes.

Issue

  • JDK-8362898: Remove finalize() methods from javax.imagio TIFF classes. (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26416/head:pull/26416
$ git checkout pull/26416

Update a local copy of the PR:
$ git checkout pull/26416
$ git pull https://git.openjdk.org/jdk.git pull/26416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26416

View PR using the GUI difftool:
$ git pr show -t 26416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26416.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2025

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8362898 8362898: Remove finalize() methods from javax.imagio TIFF classes. Jul 21, 2025
@openjdk
Copy link

openjdk bot commented Jul 21, 2025

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 22, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 22, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant