8362889: [GCC static analyzer] leak in libstringPlatformChars.c

[MBaesken]

This is reported by the gcc static analyzer (-fanalyzer); it is just test coding so not very critical but probably should still be adjusted .

/jdk/test/jdk/java/lang/String/nativeEncoding/libstringPlatformChars.c:74:12: warning: leak of 'str' [CWE-401] [-Wanalyzer-malloc-leak]
   74 | return JNU_NewStringPlatform(env, str);

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362889: [GCC static analyzer] leak in libstringPlatformChars.c (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26415/head:pull/26415
$ git checkout pull/26415

Update a local copy of the PR:
$ git checkout pull/26415
$ git pull https://git.openjdk.org/jdk.git pull/26415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26415

View PR using the GUI difftool:
$ git pr show -t 26415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26415.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e2f902f6)
• 00: Full (7d2eae0b)

[RogerRiggs]

At line 66: where it returns null, it seem like it should also be freeing str. (The analyzer didn't catch that?)

[MBaesken]

It catches that too

/jdk/test/jdk/java/lang/String/nativeEncoding/libstringPlatformChars.c:65:8: warning: leak of 'str' [CWE-401] [-Wanalyzer-malloc-leak]
   65 |     if (jbytes == NULL) {

and also

/jdk/test/jdk/java/lang/String/nativeEncoding/libstringPlatformChars.c:69:16: warning: dereference of possibly-NULL 'str' [CWE-690] [-Wanalyzer-possible-null-dereference]
   69 |         str[i] = (char)jbytes[i];
      |         ~~~~~~~^~~~~~~~~~~~~~~~~

I just overlooked it because a log of a full build with '-fanalyzer' enabled contains quite a lot of output (the event explanations of every finding are rather long).

[dholmes-ora]

Seems better to defer the malloc until after you know jbytes is not null; and also check the malloc result for null.