-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361376: Regressions 1-6% in several Renaissance in 26-b4 only MacOSX aarch64 #26399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
replace set_guard_value lock with CAS
👋 Welcome back dlong! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@dean-long The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/label hotspot-gc hotspot-compiler |
@dean-long The |
This PR removes the recently added lock around set_guard_value, using instead Atomic::cmpxchg to atomically update bit-fields of the guard value. Further, it takes a fast-path that uses the previous direct store when at a safepoint. Combined, these changes should get us back to almost where we were before in terms of overhead. If necessary, we could go even further and allow make_not_entrant() to perform a direct byte store, leaving 24 bits for the guard value.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26399/head:pull/26399
$ git checkout pull/26399
Update a local copy of the PR:
$ git checkout pull/26399
$ git pull https://git.openjdk.org/jdk.git pull/26399/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26399
View PR using the GUI difftool:
$ git pr show -t 26399
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26399.diff
Using Webrev
Link to Webrev Comment