Skip to content

8361376: Regressions 1-6% in several Renaissance in 26-b4 only MacOSX aarch64 #26399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

dean-long
Copy link
Member

@dean-long dean-long commented Jul 19, 2025

This PR removes the recently added lock around set_guard_value, using instead Atomic::cmpxchg to atomically update bit-fields of the guard value. Further, it takes a fast-path that uses the previous direct store when at a safepoint. Combined, these changes should get us back to almost where we were before in terms of overhead. If necessary, we could go even further and allow make_not_entrant() to perform a direct byte store, leaving 24 bits for the guard value.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8361376: Regressions 1-6% in several Renaissance in 26-b4 only MacOSX aarch64 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26399/head:pull/26399
$ git checkout pull/26399

Update a local copy of the PR:
$ git checkout pull/26399
$ git pull https://git.openjdk.org/jdk.git pull/26399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26399

View PR using the GUI difftool:
$ git pr show -t 26399

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26399.diff

Using Webrev

Link to Webrev Comment

replace set_guard_value lock with CAS
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2025

👋 Welcome back dlong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 19, 2025

@dean-long The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@dean-long
Copy link
Member Author

/label hotspot-gc hotspot-compiler

@dean-long dean-long marked this pull request as ready for review July 23, 2025 19:49
@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@dean-long
The hotspot-gc label was successfully added.

The hotspot-compiler label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant