Skip to content

8359760: Remove the jdk.jsobject module #26393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 18, 2025

This PR removes the terminally-deprecated jdk.jsobject module from the JDK. This module is now shipped with JavaFX, and has been since JavaFX 24.

The following files still reference jdk.jsobject (or the netscape.javascript package). They are not modified because these files reflect the state of earlier releases, which do have the jdk.jsobject module.

src/jdk.compiler/share/data/symbols/jdk.jsobject-9.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-A.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-B.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-C.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-E.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-G.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-M.sym.txt
src/jdk.compiler/share/data/symbols/jdk.jsobject-O.sym.txt
src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-8.sym.txt
src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-9.sym.txt
src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-B.sym.txt
src/jdk.compiler/share/data/symbols/jdk.scripting.nashorn-F.sym.txt
src/jdk.compiler/share/data/symbols/symbols
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/releases/element-list-10.txt
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/releases/element-list-9.txt
test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk17/element-list

I will leave this in Draft pending testing.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8362628 to be approved

Issues

  • JDK-8359760: Remove the jdk.jsobject module (Enhancement - P4)
  • JDK-8362628: Remove the jdk.jsobject module (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26393/head:pull/26393
$ git checkout pull/26393

Update a local copy of the PR:
$ git checkout pull/26393
$ git pull https://git.openjdk.org/jdk.git pull/26393/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26393

View PR using the GUI difftool:
$ git pr show -t 26393

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26393.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@kevinrushforth The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@kevinrushforth
Copy link
Member Author

/skara label client

@openjdk
Copy link

openjdk bot commented Jul 18, 2025

@kevinrushforth
The client label was successfully added.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant