Skip to content

8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events #26390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8340312: sun.security.ssl.SSLLogger uses incorrect log level ALL for finest log events #26390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/java.base/share/classes/sun/security/ssl/SSLLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public static void finer(String msg, Object... params) {
}

public static void finest(String msg, Object... params) {
SSLLogger.log(Level.ALL, msg, params);
SSLLogger.log(Level.TRACE, msg, params);
}

private static void log(Level level, String msg, Object... params) {
Expand Down
4 changes: 3 additions & 1 deletion test/jdk/sun/security/ssl/SSLLogger/DebugPropertyValuesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

/**
* @test
* @bug 8350582
* @bug 8350582 8340312
* @library /test/lib /javax/net/ssl/templates
* @summary Correct the parsing of the ssl value in javax.net.debug
* @run junit DebugPropertyValuesTest
Expand Down Expand Up @@ -80,6 +80,8 @@ public class DebugPropertyValuesTest extends SSLSocketTemplate {
debugMessages.put("java.security.debug",
List.of("properties\\[.*\\|main\\|.*" + DATE_REGEX + ".*\\]:",
"certpath\\[.*\\|main\\|.*" + DATE_REGEX + ".*\\]:"));
// "ALL" shouldn't be seen as a valid Level
debugMessages.put("javax.net.debug.logger.ALL", List.of("ALL:"));
debugMessages.put("javax.net.debug.logger",
List.of("FINE: adding as trusted certificates",
"FINE: WRITE: TLSv1.3 application_data"));
Expand Down