8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

dbriemann · 2025-07-18T13:16:41Z

Add the TimeoutFactor property to the CompileFramework to avoid timeouts on different systems.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts (Enhancement - P4)

Reviewers

Manuel Hässig (@mhaessig - Committer)
Matthias Baesken (@MBaesken - Reviewer)
Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26388/head:pull/26388
$ git checkout pull/26388

Update a local copy of the PR:
$ git checkout pull/26388
$ git pull https://git.openjdk.org/jdk.git pull/26388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26388

View PR using the GUI difftool:
$ git pr show -t 26388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26388.diff

Using Webrev

Link to Webrev Comment

…outs

bridgekeeper · 2025-07-18T13:17:19Z

👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-07-18T13:17:37Z

@dbriemann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts

Reviewed-by: mhaessig, mbaesken, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

15b5b54: 8357694: RISC-V: Several IR verification tests fail when vlen=128
644e400: 8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note
fd7f78a: 8362493: Cleanup CodeBuffer::copy_relocations_to
... and 46 more: https://git.openjdk.org/jdk/compare/5e4a2ead714814cb4eb90ca88debc226f9c75864...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mhaessig, @MBaesken, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-07-18T13:18:36Z

@dbriemann The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-07-18T13:21:00Z

Webrevs

sendaoYan · 2025-07-18T14:56:33Z

test/hotspot/jtreg/compiler/lib/compile_framework/Compile.java

@@ -40,6 +40,7 @@
 */
 class Compile {
    private static final int COMPILE_TIMEOUT = 60;
+    private static final float timeoutFactor = Float.parseFloat(System.getProperty("test.timeout.factor", "1.0"));


Should we update the copyright year.

mhaessig · 2025-07-21T08:36:08Z

test/hotspot/jtreg/compiler/lib/compile_framework/Compile.java

@@ -182,7 +183,8 @@ private static void executeCompileCommand(List<String> command) {
        int exitCode;
        try {
            Process process = builder.start();
-            boolean exited = process.waitFor(COMPILE_TIMEOUT, TimeUnit.SECONDS);
+            long timeout = COMPILE_TIMEOUT * (long)Math.pow(2, timeoutFactor-1);


Is there a reason for scaling the timeout exponentially instead of linearly, as jtreg does it and most users would expect?

I thought that I saw this documented somewhere but I cannot find it anymore and in other places it is used linearly, like you say.

I adapted it.

mhaessig · 2025-07-21T09:12:14Z

Thank you, @dbriemann, for addressing my comment. I just kicked off testing on our side and will keep you posted on the results.

mhaessig

Testing passed.

dbriemann · 2025-07-21T15:27:15Z

Thanks for your reviews!
/integrate

openjdk · 2025-07-21T15:33:01Z

@dbriemann
Your change (at version 074bbca) is now ready to be sponsored by a Committer.

RealCLanger · 2025-07-21T15:46:34Z

/sponsor

openjdk · 2025-07-21T15:48:10Z

Going to push as commit f8c8bcf.
Since your change was applied there have been 49 commits pushed to the master branch:

15b5b54: 8357694: RISC-V: Several IR verification tests fail when vlen=128
644e400: 8362611: [GCC static analyzer] memory leak in ps_core.c core_handle_note
fd7f78a: 8362493: Cleanup CodeBuffer::copy_relocations_to
... and 46 more: https://git.openjdk.org/jdk/compare/5e4a2ead714814cb4eb90ca88debc226f9c75864...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-07-21T15:48:26Z

@RealCLanger @dbriemann Pushed as commit f8c8bcf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8362602: Add test.timeout.factor to CompileFactory to avoid test time…

7853b2a

…outs

openjdk bot added the rfr Pull request is ready for review label Jul 18, 2025

openjdk bot added the hotspot-compiler [email protected] label Jul 18, 2025

sendaoYan reviewed Jul 18, 2025

View reviewed changes

update copyright header

87fdf24

mhaessig reviewed Jul 21, 2025

View reviewed changes

make timeout factor scale linearly

074bbca

mhaessig approved these changes Jul 21, 2025

View reviewed changes

MBaesken approved these changes Jul 21, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 21, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 21, 2025

RealCLanger approved these changes Jul 21, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jul 21, 2025

openjdk bot closed this Jul 21, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 21, 2025

dbriemann deleted the dlb/compile_timeout branch July 21, 2025 16:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

dbriemann commented Jul 18, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jul 18, 2025

Uh oh!

openjdk bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Jul 18, 2025

Uh oh!

mlbridge bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

sendaoYan Jul 18, 2025

Uh oh!

mhaessig Jul 21, 2025

Uh oh!

dbriemann Jul 21, 2025

Uh oh!

mhaessig commented Jul 21, 2025

Uh oh!

mhaessig left a comment

Uh oh!

dbriemann commented Jul 21, 2025

Uh oh!

openjdk bot commented Jul 21, 2025

Uh oh!

RealCLanger commented Jul 21, 2025

Uh oh!

openjdk bot commented Jul 21, 2025

Uh oh!

openjdk bot commented Jul 21, 2025

Uh oh!

Uh oh!

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

8362602: Add test.timeout.factor to CompileFactory to avoid test timeouts #26388

Conversation

dbriemann commented Jul 18, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 18, 2025

Uh oh!

openjdk bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jul 18, 2025

Uh oh!

mlbridge bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

sendaoYan Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

mhaessig Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

dbriemann Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

mhaessig commented Jul 21, 2025

Uh oh!

mhaessig left a comment

Choose a reason for hiding this comment

Uh oh!

dbriemann commented Jul 21, 2025

Uh oh!

openjdk bot commented Jul 21, 2025

Uh oh!

RealCLanger commented Jul 21, 2025

Uh oh!

openjdk bot commented Jul 21, 2025

Uh oh!

openjdk bot commented Jul 21, 2025

Uh oh!

Uh oh!

dbriemann commented Jul 18, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jul 18, 2025 •

edited

Loading

mlbridge bot commented Jul 18, 2025 •

edited

Loading