8362556: New test jdk/jfr/event/io/TestIOTopFrame.java is failing on all platforms

[egahlin]

Could I have a review of a PR that adjusts the number of frames to skip for the FileRead event? The problem was that an intermediary frame was removed during review in a dependent PR, but the offset was not updated.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362556: New test jdk/jfr/event/io/TestIOTopFrame.java is failing on all platforms (Bug - P3)

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26378/head:pull/26378
$ git checkout pull/26378

Update a local copy of the PR:
$ git checkout pull/26378
$ git pull https://git.openjdk.org/jdk.git pull/26378/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26378

View PR using the GUI difftool:
$ git pr show -t 26378

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26378.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362556: New test jdk/jfr/event/io/TestIOTopFrame.java is failing on all platforms

Reviewed-by: mgronlun, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 9dc6282: 8362169: Pointer passed to upcall may get wrong scope
• 6949e34: 8362592: Remove unused argument in nmethod::oops_do

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (755ccb10)
• 00: Full (556570bf)

[egahlin]

/integrate

[egahlin]

/integrate

[openjdk]

Going to push as commit 441dbde.
Since your change was applied there have been 10 commits pushed to the master branch:

• ee0bcc5: 8362379: Test serviceability/HeapDump/UnmountedVThreadNativeMethodAtTop.java should mark as /native
• ceb51d4: 8362829: Exclude CDS test cases after JDK-8361725
• d83346d: 8345836: Stable annotation documentation is incomplete
• ... and 7 more: https://git.openjdk.org/jdk/compare/7da274ded4a36c6314702b687fcafcda80ae08c4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit 441dbde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@egahlin The command integrate can only be used in open pull requests.