8362838: RISC-V: Incorrect matching rule leading to improper oop instruction encoding

[feilongjiang]

Same as JDK-8361892, but for riscv.

Testing:

• Tier1-3 & hotspot:tier4 on linux-riscv64

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8362838: RISC-V: Incorrect matching rule leading to improper oop instruction encoding (Bug - P3)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Yadong Wang (@yadongw - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26318/head:pull/26318
$ git checkout pull/26318

Update a local copy of the PR:
$ git checkout pull/26318
$ git pull https://git.openjdk.org/jdk.git pull/26318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26318

View PR using the GUI difftool:
$ git pr show -t 26318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26318.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362838: RISC-V: Incorrect matching rule leading to improper oop instruction encoding

Reviewed-by: fyang, yadongwang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• e6ac956: 8360520: RISC-V: C1: Fix primitive array clone intrinsic regression after JDK-8333154
• 9f796da: 8362972: C2 fails with unexpected node in SuperWord truncation: IsFiniteF, IsFiniteD
• ceb0c0f: 8360941: [ubsan] MemRegion::end() shows runtime error: applying non-zero offset 8388608 to null pointer
• ... and 35 more: https://git.openjdk.org/jdk/compare/441dbde2c3c915ffd916e39a5b4a91df5620d7f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@feilongjiang The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (237f837e)

[RealFYang]

Look good to me. Thanks for fixing this.

[yadongw]

LGTM. Can you confirm the generated code in the case of non-legal addresses for byte_map_base?

[feilongjiang]

@yadongw Thanks for the review!

LGTM. Can you confirm the generated code in the case of non-legal addresses for byte_map_base?

Yes. I added some code to allocate the JNI handler around the byte_map_base (feilongjiang@4c9b39d). We can reproduce the crash on RISC-V, and the crash is gone after applying the fix.

[feilongjiang]

@RealFYang @yadongw -- Thanks!
/integrate

[openjdk]

Going to push as commit 0ba2942.
Since your change was applied there have been 50 commits pushed to the master branch:

• fc80384: 8359827: Test runtime/Thread/ThreadCountLimit.java need loop increasing the limit
• b746701: 8363898: RISC-V: TestRangeCheckHoistingScaledIV.java fails after JDK-8355293 when running without RVV
• 2da0cda: 8363895: Minimal build fails with slowdebug builds after JDK-8354887
• ... and 47 more: https://git.openjdk.org/jdk/compare/441dbde2c3c915ffd916e39a5b4a91df5620d7f3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@feilongjiang Pushed as commit 0ba2942.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.