Skip to content

8362239: Reconcile enter_internal and reenter_internal in the ObjectMonitor code #26317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

toxaart
Copy link
Contributor

@toxaart toxaart commented Jul 15, 2025

Hi please consider the following changes:

in this PR enter_internal() and reenter_internal() methods of the ObjectMonitor are reconciled into a single enter_internal() method, which handles both paths depending on the 2nd argument.

Tested in tiers 1-3.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8362239: Reconcile enter_internal and reenter_internal in the ObjectMonitor code (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26317/head:pull/26317
$ git checkout pull/26317

Update a local copy of the PR:
$ git checkout pull/26317
$ git pull https://git.openjdk.org/jdk.git pull/26317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26317

View PR using the GUI difftool:
$ git pr show -t 26317

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26317.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@toxaart The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant