8361635: Missing List length validation in the Class-File API

[liach]

The class file format often only stores lists up to 65535 in size because size is encoded as a u2. Currently, we truncate the list size and write all contents, creating malformed class files. Almost all scenarios where such oversized lists are created can be considered an error; we should eagerly reject lists that would never be encodable in the class file format when users construct model objects.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8361906 to be approved

Issues

• JDK-8361635: Missing List length validation in the Class-File API (Bug - P4)
• JDK-8361906: Missing List length validation in the Class-File API (CSR)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26252/head:pull/26252
$ git checkout pull/26252

Update a local copy of the PR:
$ git checkout pull/26252
$ git pull https://git.openjdk.org/jdk.git pull/26252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26252

View PR using the GUI difftool:
$ git pr show -t 26252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26252.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into pr/26201 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361635: Missing List length validation in the Class-File API

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 59 new commits pushed to the master branch:

• 6dda2f6: 8366543: Clean up include headers in numberSeq
• 7c70e73: 8366660: Sort share/nmt includes
• 8c4090c: 8329077: C2 SuperWord: Add MoveD2L, MoveL2D, MoveF2I, MoveI2F
• ... and 56 more: https://git.openjdk.org/jdk/compare/ae9607725c8c6a1b2f2728dbb5f7993722497da7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full (0e74a9a5)
• 01: Full - Incremental (8b393932)
• 00: Full (4ab67b40)

[asotona]

I'm sorry, I take it back. It is OK.

[asotona]

Great job for mitigating accidental building of invalid class files!

[openjdk]

⚠️ @liach This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[liach]

/touch

[openjdk]

@liach The pull request is being re-evaluated and the inactivity timeout has been reset.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout fix/cf-list-sizes
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@liach this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout fix/cf-list-sizes
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[liach]

I have updated this patch to be against mainline. The bot has a bit of latency that it still has a bunch of warnings, but there is no merge conflicts.

[liach]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 431f467.
Since your change was applied there have been 66 commits pushed to the master branch:

• 8d23661: 8366155: Serial: Obsolete PretenureSizeThreshold
• e3b36e3: 8366401: JCK test api/java_text/DecimalFormatSymbols/serial/InputTests.html fails after JDK-8363972
• a40afdd: 8366537: Test "java/util/TimeZone/DefaultTimeZoneTest.java" is not updating the zone ID as expected
• ... and 63 more: https://git.openjdk.org/jdk/compare/ae9607725c8c6a1b2f2728dbb5f7993722497da7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 431f467.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.