-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8361190: Test java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java fails on MacOS X #26196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/26162
Are you sure you want to change the base?
Conversation
👋 Welcome back kboulanou! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@kboulanou The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few integration blockers for this PR. Any particular reason for not having these fixes at one PR ?
I thought it will explain better the relation between different tests and fixes. I understand that this will increase the chain of dependencies between PRs. Please let me know if it is better to group these PRs in one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it will explain better the relation between different tests and fixes. I understand that this will increase the chain of dependencies between PRs. Please let me know if it is better to group these PRs in one.
I think since this fix is pretty straight-forward but dependent on #26162, I'm leaning towards combining the PRs and adding a note to the other PR. I see multiple PRs possibly related though, so I'm not positive if this can apply to your other PRs.
I will combine this PR with #26162 and i will see if other PRs could be merged as well. |
Add more timeout for the test to pass.
Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26196/head:pull/26196
$ git checkout pull/26196
Update a local copy of the PR:
$ git checkout pull/26196
$ git pull https://git.openjdk.org/jdk.git pull/26196/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26196
View PR using the GUI difftool:
$ git pr show -t 26196
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26196.diff
Using Webrev
Link to Webrev Comment