-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8342705: Add dark mode for docs #26185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
I'm finding the orange link color a bit too flashy, so I created a new snapshot that uses a pale blue color for links. This results in a less striking color scheme that is more in line with the default light theme IMO. I also realized that there is no requirement in terms of a11y to use a particular link color for navigation links, so I switched to a neutral color for links in the subnavigation and sidebar, which further "calms" the layout and improves readability IMO. I haven't updated the PR yet and posting this here for discussion. |
body.theme-dark { | ||
.hljs-title.function_, | ||
.hljs-template-variable { | ||
color: #66bcce; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you can nest rules here, the browser may skip/ignore them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for me, I've tried it on Firefox, Safari and Chrome.
Documentation of CSS nesting: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting
It's implemented in all major browsers: https://caniuse.com/?search=css%20nesting
I updated the PR with changes described in my previous comment. |
Another iteration on this PR, moving the theme switcher icon in line with the main navigation links in the top navigation bar. I updated screenshots and demo docs. |
Please review an enhancement to add a dark theme to javadoc-generated API documentation. There is a new button in the top right corner that brings up a menu to switch between themes. Available options are "Light", "Dark", and "System Setting" (following the system-wide theme setting). The selected theme is stored and preserved across browser sessions.
Generated docs can be viewed here (iteration 5, module
java.base
only).Screenshots below show both themes and how to switch between them.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26185/head:pull/26185
$ git checkout pull/26185
Update a local copy of the PR:
$ git checkout pull/26185
$ git pull https://git.openjdk.org/jdk.git pull/26185/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26185
View PR using the GUI difftool:
$ git pr show -t 26185
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26185.diff
Using Webrev
Link to Webrev Comment