8361524: [XWayland] possible JavaFX interop hang

[azvegint]

Callbacks in the src/java.desktop/unix/native/libawt_xawt/awt/screencast_portal.c file normally have the following pattern:

helper->isDone = TRUE;
callbackEnd();
// return;

Failing to call callbackEnd() could result in a hang if another GTK loop is running (e.g., JavaFX see #22131 (comment)).

This fix corrects this flaw.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8361524: [XWayland] possible JavaFX interop hang (Bug - P4)

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)
• Phil Race (@prrace - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer)
• Kevin Rushforth (@kevinrushforth - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26172/head:pull/26172
$ git checkout pull/26172

Update a local copy of the PR:
$ git checkout pull/26172
$ git pull https://git.openjdk.org/jdk.git pull/26172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26172

View PR using the GUI difftool:
$ git pr show -t 26172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26172.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8361524: [XWayland] possible JavaFX interop hang

Reviewed-by: psadhukhan, serb, prr, kizune, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 232 new commits pushed to the master branch:

• 4e53a9d: 8357818: Shenandoah doesn't use shared API for printing heap before/after GC
• 8477630: 8360679: Shenandoah: AOT saved adapter calls into broken GC barrier stub
• 2f1aed2: 8361423: Add IPSupport::printPlatformSupport to java/net/NetworkInterface/IPv4Only.java
• ... and 229 more: https://git.openjdk.org/jdk/compare/ec3bb93d7901c7756d7ff4cc18e4ae9d88942f93...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bf054fae)

[kevinrushforth]

LGTM