-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8360048: NMT crash in gtest/NMTGtests.java: fatal error: NMT corruption: Block at 0x0000017748307120: header canary broken #25950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…on: Block at 0x0000017748307120: header canary broken
👋 Welcome back azafari! A progress list of the required criteria for merging this PR into |
@afshin-zafari This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 62 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@afshin-zafari The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if we could remove the dependency on the global instance in the source code and create new VMT's for each test. That would make the tests less brittle.
rtree = VirtualMemoryTracker::Instance::tree(); | ||
rtree->tree().remove_all(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I asked about this before - can we do remove_all in the constructor to avoid this 2 line repeating pattern?
Otherwise looks good, can you please check the GHA test failures on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's the right way to go. I think it's better if we can avoid using the global instance, and not change the code of the VMT in order to appease the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I suggested the easiest fix I could think of, but doing it this way is even better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The canary header test failed since there were concurrent
remove
andfree()
from the tree. Theremove
operations are synch'ed with corresponding NMT lock. TheReserveMemory::reserve()
uses the same lock internally and is not included in the locked code block.Tests: tier5 {macosx-aarch64, linux-x64, windows-x64} x {debug, release}
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25950/head:pull/25950
$ git checkout pull/25950
Update a local copy of the PR:
$ git checkout pull/25950
$ git pull https://git.openjdk.org/jdk.git pull/25950/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25950
View PR using the GUI difftool:
$ git pr show -t 25950
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25950.diff
Using Webrev
Link to Webrev Comment