-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8344159: Add lint warnings for unnecessary warning suppression #25167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@archiecobbs This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a |
/touch |
@archiecobbs The pull request is being re-evaluated and the inactivity timeout has been reset. |
This PR adds a new Lint category
"suppression"
and associated warnings for@SuppressWarnings
annotations that are unnecessary because they don't actually suppress any warnings.Summary of changes:
"suppression"
(disabled by default) and an associated warning for@SuppressWarnings
annotations that don't actually suppress any warnings.LintMapper
to keep track of which@SuppressWarnings
suppressions have been validated¹ and (later) generate warnings about those that never were.Log.warning()
so it automatically validates any current suppression of the warning's lint category in effect.Lint.isEnabled()
andLint.isSuppressed()
with a new parameterboolean validate
that specifies whether to also validate any current suppression.Lint.isActive()
to check whether a category is enabled or suppression of the category is being tracked - in other words, the calculation for the warning needs to be performed. This is used when the calculation of a warning is non-trivial making it worth checking whether it should be skipped.*.gmk
build files to add-Xlint:-suppression
flags so that the build doesn't break (the JDK itself contains hundreds of unnecessary@SuppressWarnings
annotations).Prerequisites to this PR:
¹ The suppression of a lint category is "validated" as soon as it suppresses some warning in that category
Progress
Warning
6723459: javac to flag where warning suppression is not required
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25167/head:pull/25167
$ git checkout pull/25167
Update a local copy of the PR:
$ git checkout pull/25167
$ git pull https://git.openjdk.org/jdk.git pull/25167/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25167
View PR using the GUI difftool:
$ git pr show -t 25167
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25167.diff