8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

[tkiriyama]

Hi All,
I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java.
I was unable to reproduce the reported problem in java versions 11 and later. Therefore, I made a pull request for 8u before.
openjdk/jdk8u-dev#641
However, the latest java should be fixed, as the bugs described below will potentially remain in the test.

This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
Change has been verified locally, test-fix only, no risk.

Would someone please review this fix?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24646/head:pull/24646
$ git checkout pull/24646

Update a local copy of the PR:
$ git checkout pull/24646
$ git pull https://git.openjdk.org/jdk.git pull/24646/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24646

View PR using the GUI difftool:
$ git pr show -t 24646

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24646.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

• 55afcb5: 8352682: Opensource JComponent tests
• 5526490: 8354565: jtreg failure handler GatherProcessInfoTimeoutHandler has a leftover call to System.loadLibrary
• a2dc9c7: 8352908: Open source several swing tests batch1
• ... and 55 more: https://git.openjdk.org/jdk/compare/cf0308b2716053eb7c547cfcc6b160589cd6a2b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@tkiriyama The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (31676205)

[phohensee]

Looks fine to me.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version 3167620) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

Trivial.

[openjdk]

Going to push as commit c3de94c.
Since your change was applied there have been 75 commits pushed to the master branch:

• 465c8e6: 8349721: Add aarch64 intrinsics for ML-KEM
• 1ad869f: 8322706: AnnotationTypeMismatchException in javac with annotation processing
• 7ffad35: 8352568: Test gtest/AsyncLogGtest.java failed at droppingMessage_vm
• ... and 72 more: https://git.openjdk.org/jdk/compare/cf0308b2716053eb7c547cfcc6b160589cd6a2b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @tkiriyama Pushed as commit c3de94c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.