8354448: [REDO] Remove friends for ObjectMonitor

[coleenp]

This is a redo of the trivial change that failed. The second commit is the method I should have added.
Tested with tier1-4, where tier3 has the code to exercise LockingMode=1.
Thanks,
Coleen

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8354448: [REDO] Remove friends for ObjectMonitor (Bug - P4)

Reviewers

• Kim Barrett (@kimbarrett - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24626/head:pull/24626
$ git checkout pull/24626

Update a local copy of the PR:
$ git checkout pull/24626
$ git pull https://git.openjdk.org/jdk.git pull/24626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24626

View PR using the GUI difftool:
$ git pr show -t 24626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24626.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354448: [REDO] Remove friends for ObjectMonitor

Reviewed-by: kbarrett, shade, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 3090e21: 8353572: x86: AMD platforms miss the check for CLWB feature flag
• 76ff978: 8354510: Skipped gtest cause test failure
• c7b70a1: 8354111: JavaDoc states that Iterator.remove() is linear in the LinkedBlockingDeque
• ... and 26 more: https://git.openjdk.org/jdk/compare/d14e84c03b681594e84aef28107dce7b5198893b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (db5c99f4)

[kimbarrett]

Looks good. I didn't find it trivial though.

[coleenp]

Thanks for the reviews. I'll not treat it as trivial and wait. Once bitten (not burned) twice shy.

[dholmes-ora]

It probably would have helped if set_recursions had a comment stating what it is used for (which seems to be setting recursions when an anonymously owned monitor is given its true owner details).

Updated fix is fine. Thanks

[dholmes-ora]

May be overkill to have this assert ...

[coleenp]

Yeah this method will be removed with legacy locking.

[coleenp]

Thanks for reviewing.
/integrate

[openjdk]

Going to push as commit 273a9a6.
Since your change was applied there have been 36 commits pushed to the master branch:

• 5fc18f5: 8350279: HttpClient: Add a new HttpResponse method to identify connections
• 03fd43f: 8353453: URLDecoder should use HexFormat
• 4e24dc0: 8353185: Introduce the concept of upgradeable files in context of JEP 493
• ... and 33 more: https://git.openjdk.org/jdk/compare/d14e84c03b681594e84aef28107dce7b5198893b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 273a9a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.