Skip to content

Correct documentation for --linux-package-deps #23638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StefanLobbenmeier
Copy link

@StefanLobbenmeier StefanLobbenmeier commented Feb 14, 2025

The documentation suggests that --linux-package-deps is a boolean option, while in fact it is a string option with dependencies separated by comma and space

You can tell that this option is supposed to have an argument here:

private static final BundlerParamInfo<String> LINUX_PACKAGE_DEPENDENCIES =
new StandardBundlerParam<>(
Arguments.CLIOptions.LINUX_PACKAGE_DEPENDENCIES.getId(),
String.class,
params -> "",
(s, p) -> s
);


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23638/head:pull/23638
$ git checkout pull/23638

Update a local copy of the PR:
$ git checkout pull/23638
$ git pull https://git.openjdk.org/jdk.git pull/23638/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23638

View PR using the GUI difftool:
$ git pr show -t 23638

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23638.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Feb 14, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2025

Hi @StefanLobbenmeier, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user StefanLobbenmeier" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Feb 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Feb 14, 2025

@StefanLobbenmeier The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@StefanLobbenmeier
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Feb 14, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 14, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@StefanLobbenmeier
Copy link
Author

See also JetBrains/compose-multiplatform#5227 for a discussion if this option has an argument

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2025

@StefanLobbenmeier This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@StefanLobbenmeier
Copy link
Author

Just gonna try /signed again, but I didn’t get any more information from oracle

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2025

@StefanLobbenmeier This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant