Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IP Addresses as a format #237

Merged
merged 1 commit into from
Mar 4, 2025
Merged

IP Addresses as a format #237

merged 1 commit into from
Mar 4, 2025
+26 −10

Conversation

appsdesh
Copy link
Contributor

IP Addresses as a format

Closes #201

continuing from #206

@appsdesh appsdesh requested a review from a team as a code owner February 25, 2025 18:47
@appsdesh appsdesh mentioned this pull request Feb 25, 2025
Closed
timcappalli
timcappalli previously requested changes Feb 25, 2025
View reviewed changes
@appsdesh @apoorvadeshpande-okta
IP Addresses as a format
daf4e0c 
IP Addresses as a format
tulshi
tulshi approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@tulshi tulshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer ips, but ip-addresses is OK too.

@tulshi tulshi added the v1Final Issues that must be fixed before we propose a spec to become a v1 final spec. label Mar 3, 2025
iamseanodentity
iamseanodentity approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@iamseanodentity iamseanodentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@tulshi tulshi dismissed timcappalli’s stale review March 4, 2025 19:13

request has been addressed.

@tulshi tulshi merged commit 8f83051 into main Mar 4, 2025
1 of 2 checks passed
@tulshi tulshi deleted the ip-subject-new branch March 4, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulshi tulshi tulshi approved these changes

@iamseanodentity iamseanodentity iamseanodentity approved these changes

@timcappalli timcappalli Awaiting requested review from timcappalli

@FragLegs FragLegs Awaiting requested review from FragLegs

Assignees
No one assigned
Labels
v1Final Issues that must be fixed before we propose a spec to become a v1 final spec.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A list of IPs as a new subject member in SSF
4 participants
@appsdesh @timcappalli @tulshi @iamseanodentity