Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor section 10 #233

Merged
merged 27 commits into from
Mar 5, 2025
Merged

Refactor section 10 #233

merged 27 commits into from
Mar 5, 2025

Conversation

tulshi
Copy link
Contributor

@tulshi tulshi commented Feb 12, 2025

Re-factored all content from the previous "Section 10: Profiles". Parts went to the "Events" section (which used to be called the "Event Properties" section), and other parts went to a newly created section called "Event Delivery".

Since this is a refactoring, no new normative language has been added. However, it adds the "event_data" field that is described in issue #221

@tulshi tulshi changed the title Refactor section 10 and adds "event_data" Refactor section 10 Feb 13, 2025
Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added issues #223 , #202 , and points 3 and 4 from #228 as sub-tasks of the issue this PR is closing. Can you address them in this PR as well?

tulshi and others added 2 commits March 3, 2025 13:44
@tulshi tulshi requested a review from FragLegs March 3, 2025 21:46
@tulshi tulshi added the v1Final Issues that must be fixed before we propose a spec to become a v1 final spec. label Mar 3, 2025
@tulshi tulshi linked an issue Mar 4, 2025 that may be closed by this pull request
@tulshi tulshi requested review from FragLegs and appsdesh March 4, 2025 23:34
@tulshi tulshi merged commit d60a096 into main Mar 5, 2025
2 checks passed
@tulshi tulshi deleted the move-sec-10 branch March 5, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1Final Issues that must be fixed before we propose a spec to become a v1 final spec.
Projects
None yet
4 participants