-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor section 10 #233
Merged
Merged
Refactor section 10 #233
+182
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating ruby version
updating source file to trigger build
fixed typo
removing version number for ruby
This was
linked to
issues
Feb 12, 2025
appsdesh
reviewed
Feb 13, 2025
appsdesh
approved these changes
Feb 13, 2025
jischr
approved these changes
Feb 14, 2025
Co-authored-by: Jen Schreiber <[email protected]>
FragLegs
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Shayne Miel (he/him) <[email protected]>
Co-authored-by: Shayne Miel (he/him) <[email protected]>
FragLegs
requested changes
Mar 4, 2025
Co-authored-by: Shayne Miel (he/him) <[email protected]>
Co-authored-by: Shayne Miel (he/him) <[email protected]>
tulshi
commented
Mar 4, 2025
… and refered to section 6.1 (Stream Configuration Metadata)
FragLegs
approved these changes
Mar 5, 2025
appsdesh
reviewed
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factored all content from the previous "Section 10: Profiles". Parts went to the "Events" section (which used to be called the "Event Properties" section), and other parts went to a newly created section called "Event Delivery".
Since this is a refactoring, no new normative language has been added. However, it adds the "event_data" field that is described in issue #221