Issue 163 - add field to configuration data indicating expected subject behavior for new streams #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct behavior for new streams
tulshi
reviewed
May 17, 2024
tulshi
approved these changes
May 21, 2024
appsdesh
reviewed
May 23, 2024
|
Deferring to @appsdesh on this one. |
@timcappalli You would need approve in order for us to be able to merge (or @iamseanodentity can) |
|
I just caught up on the fireworks :) |
tulshi
approved these changes
Jun 13, 2024
appsdesh
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #163 by adding an optional field,
default_subjectsto the Transmitter Configuration data. The field is a string which can be eitherALLorNONEand defaults toNONEif not provided. The interpretation of this field is as follows:ALL: All subjects are added by default. Callingremove_subject_endpointacts like a filter, blocking the transmission of only the specified subjects. Callingadd_subject_endpointcan effectively clear any filters set byremove_subject_endpointbut otherwise does nothing.NONE: No subjects are added by default. Callingadd_subject_endpointadds a subject to the stream. Callingremove_subject_endpointcan remove a previously added subject, but otherwise does nothing.