Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 163 - add field to configuration data indicating expected subject behavior for new streams #168

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

FragLegs
Copy link
Contributor

Addresses issue #163 by adding an optional field, default_subjects to the Transmitter Configuration data. The field is a string which can be either ALL or NONE and defaults to NONE if not provided. The interpretation of this field is as follows:

  • ALL: All subjects are added by default. Calling remove_subject_endpoint acts like a filter, blocking the transmission of only the specified subjects. Calling add_subject_endpoint can effectively clear any filters set by remove_subject_endpoint but otherwise does nothing.
  • NONE: No subjects are added by default. Calling add_subject_endpoint adds a subject to the stream. Calling remove_subject_endpoint can remove a previously added subject, but otherwise does nothing.

@FragLegs FragLegs requested a review from a team as a code owner May 16, 2024 14:42
@FragLegs FragLegs linked an issue May 24, 2024 that may be closed by this pull request
@tulshi tulshi requested a review from timcappalli May 24, 2024 20:35
@timcappalli
Copy link
Member

Deferring to @appsdesh on this one.

@timcappalli timcappalli removed their request for review June 10, 2024 17:02
@tulshi
Copy link
Contributor

tulshi commented Jun 10, 2024

Deferring to @appsdesh on this one.

@timcappalli You would need approve in order for us to be able to merge (or @iamseanodentity can)

@iamseanodentity
Copy link
Contributor

I just caught up on the fireworks :)

Copy link
Contributor

@appsdesh appsdesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying it

@tulshi tulshi merged commit a4fde6f into main Jun 13, 2024
2 checks passed
@tulshi tulshi deleted the 163-default-behavior-no-subjects branch June 13, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify expected default behavior of streams with no subjects
5 participants