-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing transmitter supplied fields from stream config PUT and PATCH… #152
Conversation
@FragLegs, @appsdesh, @atultulshi Can you please review the PR and approve/comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing language already clarifies -
Transmitter-Supplied properties beside the stream_id MAY be present,
but they MUST match the expected value. Missing Transmitter-Supplied
properties MUST be ignored by the Transmitter.
There may be reasons for the receiver to send the same values to make sure it's info matches the Tx info (and expect to receive error message, on mismatch)
I don't think this PR is needed. Please let me know your thoughts
The issue addressed by this PR is not if the fields can or can't be in the request but the fact that having a the fields in the examples is confusing. Having transmitter-supplied fields in an update request is an edge case and while it is allowed, it doesn't make sense to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Examples without the transmitter supplied fields are clearer, so this is a net benefit to the spec.
Removed the transmitter supplied fields from the stream config PUT and PATCH examples.