signed issuer metadata #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
reviewed
Mar 11, 2025
| @@ -118,6 +118,10 @@ Both the Wallet and the Credential Issuer: | |||
|
|
|||
| Both Wallet initiated and Issuer initiated issuance is supported. | |||
|
|
|||
| ## Issuer Metadata | |||
|
|
|||
| Support for signed Issuer Metadata to allow for Issuer authentication via the `signed_metadata` parameter in the Issuer Metadata is RECOMMENDED. When required by ecosystem policy, signed Issuer Metadata MUST be supported by both the Wallet and the Issuer. Key resolution to validate the signed Issuer Metadata via the `x5c` header parameter in the JWT MUST be supported for signed Issuer Metadata. | |||
There was a problem hiding this comment.
Suggested change
| Support for signed Issuer Metadata to allow for Issuer authentication via the `signed_metadata` parameter in the Issuer Metadata is RECOMMENDED. When required by ecosystem policy, signed Issuer Metadata MUST be supported by both the Wallet and the Issuer. Key resolution to validate the signed Issuer Metadata via the `x5c` header parameter in the JWT MUST be supported for signed Issuer Metadata. | |
| To support signed Issuer Metadata to allow for Issuer authentication, it is | |
| RECOMMENDED to use the `signed_metadata` parameter in the Issuer Metadata. | |
| When required by ecosystem policy, signed Issuer Metadata MUST be supported by | |
| both the Wallet and the Issuer. Key resolution to validate the signed Issuer Metadata | |
| MUST be supported using the `x5c` header parameter in the JWT. |
I would like to be more explicit.
- can we please put reference to
x5cparameter?
Sakurann
requested review from
danielfett,
jogu,
tplooker,
paulbastian,
awoie and
bc-pi
Co-authored-by: Kristina <[email protected]>
…nto 156-signed-metadata
Sakurann
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #156
I added the RECOMMENDED part - happy to remove if WG is not comfortable with it.