Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to various sections in OID4VP + copyright year + some broken links #159

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

jogu
Copy link
Contributor

@jogu jogu commented Jan 28, 2025

Incorrect JWE section link was pointed out by Martijn (thanks!)

Incorrect JWE section link was pointed out by Martijn (thanks!)
@jogu jogu added the editorial label Jan 28, 2025
@c2bo
Copy link
Member

c2bo commented Jan 28, 2025

There seem to be more references for OpenID4VP that are broken (or rather got shifted). Another one I saw glancing over was:

  • Response mode MUST be direct_post.jwt. The Verifier MUST return redirect_uri in response to the HTTP POST request from the Wallet, where the Wallet redirects the User to, as defined in Section 7.2 of [@!OIDF.OID4VP]. Implementation considerations for the response mode direct_post.jwt are given in Section 12.4 of [@!OIDF.OID4VP].

I believe those should be 8.2 and 14.3 (sorry, can't create comments on text outside of the scope of the PR).

Also fix date for -24 of VP to match the published doc.
@jogu
Copy link
Contributor Author

jogu commented Jan 28, 2025

Thanks @c2bo - I fixed those!

@jogu jogu changed the title Fix link to JWE section in OID4VP + copyright right + some broken links Fix links to various sections in OID4VP + copyright year + some broken links Jan 28, 2025
@Sakurann Sakurann merged commit 1e4d6ac into main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants