Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add example for sessiontranscript related structures #449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awoie
Copy link
Contributor

@awoie awoie commented Mar 6, 2025

This PR is non-normative and just provides an example for SessionTranscript-related objects specific for DC API.

Fixes #425

@awoie
Copy link
Contributor Author

awoie commented Mar 6, 2025

Unsure if we need both, hex and CBOR diag (which contains hex).

@jogu
Copy link
Collaborator

jogu commented Mar 6, 2025

This kinda conflicts with #448 which removed client_id from the session transcsript :(

@awoie awoie requested review from mickrau, leecam and TimoGlastra March 6, 2025 15:08
@Sakurann
Copy link
Collaborator

Sakurann commented Mar 11, 2025

This kinda conflicts with #448 which removed client_id from the session transcsript :(

can the example be modified to remove client_id?

@awoie
Copy link
Contributor Author

awoie commented Mar 17, 2025

This kinda conflicts with #448 which removed client_id from the session transcsript :(

can the example be modified to remove client_id?

yep, it can. i will update this PR once #400 got resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example SessionTranscript
3 participants