Fixes various issues in authorization request handlers #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixtron
commented
Dec 6, 2019
pixtron
commented
Dec 6, 2019
| this.locationLike.assign(url); | ||
| resolve(null); | ||
| }) | ||
| .catch(error => reject(error)); |
There was a problem hiding this comment.
Catch and bubble up errors to avoid unhandled promise rejection.
tikurahul
reviewed
Dec 6, 2019
|
@tikurahul could you check the PR again after my changes regarding your comments? |
|
@tikurahul We are interested in having this PR releases as it addresses our security concerns. |
|
@tikurahul please let me know if there is something holding you back merging this PR. |
|
@tikurahul Sorry, thank you for seeing this PR. |
|
Hi, do you still consider to merge this pull request as we are pretty interested in those changes? |
|
+1 |
|
any reason why this hasn't been merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeBasedHandlerserver startup error (eg:EADDRINUSE) Uncaught error is thrown when port for notifier server is already in use #95NodeBasedHandleronly opens authorization url if server could be successfully started, to avoid leaking Tokens to another process listening on the configured port.NodeBasedHandlernow only binds to loopback (127.0.0.1) interface Notifier server should only bind to loopback interface #93