Fix item type validation test and Java 21 deprecations#562
Open
wborn wants to merge 3 commits into
Open
Conversation
Generate the expected invalid item type message from the current thing description schema instead of hard-coding the full item type enumeration. This keeps the test stable when new item types are added to the XSD. Also replace deprecated Java 21 API usage for Locale and URL creation. Signed-off-by: Wouter Born <github@maindrain.net>
There was a problem hiding this comment.
Pull request overview
This PR updates OhInfXmlValidationCheckTest to keep the invalid item type validation test aligned with the current thing-description XSD and removes deprecated Locale/URL constructor usage in the touched test code.
Changes:
- Generates the expected invalid item type error message from the fetched XSD enumeration.
- Replaces
new Locale("en", "US")withLocale.US. - Replaces test-side
new URL(...)construction withURI.create(...).toURL().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 31, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate the expected invalid item type message from the current thing description schema instead of hard-coding the full item type enumeration. This keeps the test stable when new item types are added to the XSD.
Also replace deprecated Java 21 API usage for Locale and URL creation.