[BasicUI] Fix updating of the chart period parameter in URL #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
enhancement
Job #1239: Bundle Size — 15.75MiB (-0.08%).Important Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages Warning Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages Bundle metrics
  
Bundle size by type
View job #1239 report View lolodomo:chart_6M_2Y branch activity |
lolodomo
changed the title
lolodomo
force-pushed
the
chart_6M_2Y
branch
from
e0188bf to
ee1418f
Compare
lolodomo
changed the title
The period parameter syntax was extended. Depends on openhab/openhab-core#3863 Also add few new default periods in the selection of chart period Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
chart_6M_2Y
branch
from
ee1418f to
8870ca0
Compare
lolodomo
changed the title
|
LGTM I will look into adapting the UI sitemap definition checks. |
|
@kaikreuzer : a small change that is a consequence of the change in core. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The period parameter syntax was extended.
Depends on openhab/openhab-core#3863
Also add few new default periods in the selection of chart period
Signed-off-by: Laurent Garnier [email protected]