Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon] Fix localisation of suggested Add-ons #3905

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Dec 8, 2023

Fixes #2204

Since time is of the essence, I am opening this PR now for code review. I will create and test a full OH build tomorrow.

Signed-off-by: Andrew Fiddian-Green [email protected]

Signed-off-by: Andrew Fiddian-Green <[email protected]>
@andrewfg andrewfg requested a review from a team as a code owner December 8, 2023 19:24
@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 8, 2023

@mherwege 4yi..

@mherwege
Copy link
Contributor

mherwege commented Dec 8, 2023

I think this should do.
LGTM

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@kaikreuzer kaikreuzer merged commit bb30eab into openhab:main Dec 9, 2023
2 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Dec 9, 2023
@andrewfg
Copy link
Contributor Author

andrewfg commented Dec 9, 2023

I think this should do.

I tested it today, and unfortunately it does not work!

@kaikreuzer you should DEFINITELY revert this merge
@mherwege can you please take over trying to find the fix for this issue?

kaikreuzer added a commit that referenced this pull request Dec 9, 2023
@kaikreuzer
Copy link
Member

Reverted.

@andrewfg andrewfg deleted the addon-fix-2204 branch August 25, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial setup: @text/xxx instead of binding name
3 participants