[Sitemap] Change syntax for Buttongrid sitemap element #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kaikreuzer : please have a quick look at this small change. While implementing the Buttongrid widget in Basic UI and playing with it, I realized that we made a wrong choice to how identifying the position in the grid. |
lolodomo
force-pushed
the
buttongrid_line_column
branch
from
172e39e to
36e9482
Compare
mherwege
reviewed
Dec 4, 2023
...core.io.rest.sitemap/src/main/java/org/openhab/core/io/rest/sitemap/internal/MappingDTO.java
Outdated
Show resolved
Hide resolved
Follow-up openhab#3810 Location in the grid is now defined by a row number and a column number. Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
force-pushed
the
buttongrid_line_column
branch
from
36e9482 to
ab40429
Compare
|
Thank you Kai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #3810
Location in the grid is now defined by a row number and a column number.
Signed-off-by: Laurent Garnier [email protected]