Fix AutoUpdatePolicy for channel

[jlaur]

Fixes #3887

[J-N-K]

Thanks. That is really a nasty bug.

[J-N-K]

Can you add a test-case for this, too? The test should show that

• no policy is set if neither the channel-definition nor the channel-type-definition set a policy
• if either channel- or channel-type-definition contain a policy, it is used
• if both contain a policy, the channel-definition takes precedence

[jlaur]

Just to be sure, you mean a new test class, right? I didn't find any existing coverage.

[jlaur]

I'm afraid I need a bit of guidance here. I found some integration tests that seem related:

openhab-core/itests/org.openhab.core.thing.tests/src/main/java/org/openhab/core/thing/internal/ThingManagerOSGiJavaTest.java

Lines 347 to 382 in 3624682

	@Test
	public void testCreateChannelGroupBuilder() throws Exception {
	AtomicReference<ThingHandlerCallback> thc = initializeThingHandlerCallback();
	List<ChannelBuilder> channelBuilders = thc.get().createChannelBuilders(CHANNEL_GROUP_UID,
	CHANNEL_GROUP_TYPE_UID);
	assertNotNull(channelBuilders);
	assertEquals(2, channelBuilders.size());
	assertNotNull(channelBuilders.get(0));
	validateChannel(channelBuilders.get(0).build());
	assertNotNull(channelBuilders.get(1));
	validateChannelOverridden(channelBuilders.get(1).build());
	}
	private void validateChannel(Channel channel) {
	assertNotNull(channel);
	assertEquals("Test Label", channel.getLabel());
	assertEquals("Test Description", channel.getDescription());
	assertEquals(CoreItemFactory.SWITCH, channel.getAcceptedItemType());
	assertEquals(CHANNEL_TYPE_UID, channel.getChannelTypeUID());
	assertNotNull(channel.getDefaultTags());
	assertEquals(1, channel.getDefaultTags().size());
	assertEquals("Test Tag", channel.getDefaultTags().iterator().next());
	}
	private void validateChannelOverridden(Channel channel) {
	assertNotNull(channel);
	assertEquals("Test Label Overridden", channel.getLabel());
	assertEquals("Test Description Overridden", channel.getDescription());
	assertEquals(CoreItemFactory.SWITCH, channel.getAcceptedItemType());
	assertEquals(CHANNEL_TYPE_UID, channel.getChannelTypeUID());
	assertNotNull(channel.getDefaultTags());
	assertEquals(1, channel.getDefaultTags().size());
	assertEquals("Test Tag", channel.getDefaultTags().iterator().next());
	}

Did you mean to add new tests here? In that case, how can I build and run those tests?

[J-N-K]

I think we are good for now. We should off proper testing for the whole class in a later PR, that is out of scope here.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/autoupdatepolicy-seems-to-be-ignored-on-xml-channel-definitions/149271/3