Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JavaDoc build badge and reconfigure plugin to indicate JavaDoc warnings/errors #3886

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Add JavaDoc build badge and reconfigure plugin to indicate JavaDoc warnings/errors #3886

merged 1 commit into from
Nov 26, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Nov 25, 2023 •
edited
Loading

  • Add JavaDoc build badge
  • Add dependency to upgradetool to fix remaining JavaDoc error
  • Fail JavaDoc build on JavaDoc warnings/errors
  • Upgrade maven-javadoc-plugin to fix it failing even if there are no warnings/errors
  • Enable legacyMode to workaround JPMS issues in newer maven-javadoc-plugin versions

@wborn
Add JavaDoc build badge and reconfigure plugin to indicate JavaDoc wa…
de01236 
…rnings/errors

* Add JavaDoc build badge
* Add dependency to upgradetool to fix remaining JavaDoc error
* Fail JavaDoc build on JavaDoc warnings/errors
* Upgrade maven-javadoc-plugin to fix it failures even if there are no warnings/errors
* Enable legacyMode to workaround JPMS issues in newer maven-javadoc-plugin versions

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn requested a review from a team as a code owner November 25, 2023 14:31
@wborn wborn mentioned this pull request Nov 25, 2023
Merged
kaikreuzer
kaikreuzer approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 3624682 into openhab:main Nov 26, 2023
2 checks passed
@kaikreuzer kaikreuzer added this to the 4.1 milestone Nov 26, 2023
@wborn wborn deleted the javadoc-build-status branch November 26, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @kaikreuzer